Consistent multiline spacing and tests, with extra space #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased because the changes in _imagingft.c to add getters for |
|
I'd say keep the getters. It's not private information. |
wiredfool
added a commit
that referenced
this pull request
Dec 7, 2015
Consistent multiline spacing and tests, with extra space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the inconsistent multiline spacing reported in #1540.
It includes the fix from @wiredfool and I updated the tests. I checked the baseline-to-baseline heights in the new images and they're equal.
In PR #1573 I noticed the lines are a bit close together by default. So I set the spacing to four pixels by default instead of zero.
Here's the PR without extra spacing by default, and so either that or this should be merged, not both.