Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also switch TIFFImagePlugin to logging #1589

Closed
wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 9, 2015

Just some mechanical changes. The remaining file using print is OLEFile,
which has its own logic, but I noticed that @decalage's bitbucket repo has now
switched to using logging as well.

Just some mechanical changes.  The remaining file using print is OLEFile,
which has its own logic, but I noticed that @decalage's bitbucket repo has now
switched to using logging as well.
@wiredfool
Copy link
Member

Please don't.

Most of the debugging in these is setup for debugging at dev time, not runtime debugging of images that are bad. When something happens with an image, they get dumped into the django logs and they confuse people.

That's been a problem with switching the other devugging to logs, but I think it would wind up being worse for this because most of them are a far lower level of information.

@anntzer
Copy link
Contributor Author

anntzer commented Dec 9, 2015

I don't know what the exact problem is but I'd guess this is just due to people adding a logger at the debug level to the root handler (hey, they're asking for debug info from all librairies...). On the other hand I don't really care either. Feel free to revert #1205 as well.

@radarhere radarhere changed the title Also switch TIFFImagePlugin to logging. Also switch TIFFImagePlugin to logging Jan 29, 2016
@wiredfool wiredfool closed this Mar 14, 2016
@anntzer anntzer deleted the tiff-logging branch June 10, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants