Partial fix for #1597 #1620
Merged
Partial fix for #1597 #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haven't excercized all of the metadata that we're allowing yet, and there's clearly still something up with Arrays, as one of them is still crashing and making it impossible to save a palette with a libtiff image.
|
Tests are way more complete. Arrays are still somewhat messed up, but on the whole, we're better off than we were before this PR. (meaning, arrays were messed up, now they're blocked rather than crashing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the bright side, it's not segfaulting with that image anymore.
This is built off of the IFDRational branch due to changes that I wanted to use.