Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed for wildcard paths in multiple platforms in pilfile script #1785

Closed
wants to merge 1 commit into from

Conversation

radarhere
Copy link
Member

I can't see any reason why this would be win32 only. If anyone knows, please just say.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.879% when pulling d0fc67f on radarhere:pilfile into 4d234fb on python-pillow:master.

@hugovk
Copy link
Member

hugovk commented Apr 3, 2016

I reckon it's because POSIX shells will expand unescaped wildcard arguments into a list of matching files before giving them to Python. Windows just passes on the wildcarded argument.

So the Python script needs to expand wildcards for Windows. There's no need to run that on non-Windows.

See http://breathmintsforpenguins.blogspot.com/2013/09/python-crossplatform-handling-of.html

@radarhere
Copy link
Member Author

Yep, looks like you're right. Thanks for pointing that out.

@radarhere radarhere closed this Apr 3, 2016
@radarhere radarhere deleted the pilfile branch April 3, 2016 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants