Setup cleanup #1790
Merged
Setup cleanup #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiredfool
force-pushed
the
setup_cleanup
branch
from
11cbff6
to
954abf3
Compare
Sorry, couldn't resist. As for the issues you raised, they are unfortunately not surprising. Our setup.py has to be complex, but doesn't need to be complicated. I've been trying to avoid a complete rewrite, but maybe it's time.
|
Changes Unknown when pulling 233afec on wiredfool:setup_cleanup into * on python-pillow:master*. |
|
Changes Unknown when pulling 233afec on wiredfool:setup_cleanup into * on python-pillow:master*. |
| print("library, and set the corresponding ROOT variable in the") | ||
| print("setup.py script.") | ||
| print("library and headers.") | ||
| print("See http://pillow.readthedocs.org/en/latest/installation.html#building-from-source") |
There was a problem hiding this comment.
That reminds me, because of the way that RTD is setup with versions, I can't find a deep permalink for the installation docs. Which means that all of the googable links to the documentation 404 eventually, unless they're going off of latest.
|
Looks good to merge. |
|
Changes Unknown when pulling a2bc14c on wiredfool:setup_cleanup into * on python-pillow:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I'm trying to track down a compile error on one of my machines and the hood came off setup.py and I nearly threw up a little.
So.
Some continuing WTFs:
The debug logging isn't complete, and it's still not answering my compile question. Comments welcome.
Fixes #679