Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test saving TIFF with JPEGTables tag #1804

Merged
merged 5 commits into from Apr 4, 2016

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 4, 2016

Used to fail, now passes.

See #975

Let's retain the test to keep it that way.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ba817af on hugovk:tiff_jpegtables into * on python-pillow:master*.

@wiredfool
Copy link
Member

For stuff that's this old, it's really better to make a new branch off of master and cherry pick the commits into it.

@hugovk
Copy link
Member Author

hugovk commented Apr 4, 2016

Can do. Or how about trying GitHub's brand new "squash and merge"?

https://github.com/blog/2141-squash-your-commits

@wiredfool wiredfool merged commit bb91abe into python-pillow:master Apr 4, 2016
@wiredfool
Copy link
Member

Yeah, why not. The full diff looks reasonable enough.

edit -- dammit, didn't click the right one

@hugovk hugovk deleted the tiff_jpegtables branch April 4, 2016 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants