Valid range for baseline jpeg qtables 0 to 255 #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g signed char instead of unsigned char. added test
|
Changes Unknown when pulling b38c32e on thebostik:jpeg-qtable-bounds into * on python-pillow:master*. |
…sing signed char instead of unsigned char. added test
|
Changes Unknown when pulling 5025bdd on thebostik:jpeg-qtable-bounds into * on python-pillow:master*. |
| @@ -314,6 +314,10 @@ def test_qtables(self): | |||
| 30) | |||
| self.assert_image_similar(im, self.roundtrip(im, qtables='keep'), 30) | |||
|
|
|||
| # valid bounds for baseline qtable | |||
| bounds_qtable = [int(s) for s in ("255 1 " * 32).split(None)] | |||
There was a problem hiding this comment.
bounds_qtable = [ 255, 1] *32 seems far clearer.
on the other hand, that is what the rest of them look like...
thebostik
added a commit
to thebostik/Pillow
that referenced
this pull request
May 23, 2016
And there was a lingering bug since the previous qtable unsigned char fix (python-pillow#1814) since the call to array.array was in another place, the roundtrip was no longer equivalent. That was a minor change, but the revised test wouldn't pass because saving an image with one custom qtable automatically adds a second to it by the call to jpeg_set_defaults. With 1 or >2 custom tables, there is extra work we have to do due to that call.
Fahad-Alsaidi
pushed a commit
to Fahad-Alsaidi/Pillow
that referenced
this pull request
Dec 13, 2016
And there was a lingering bug since the previous qtable unsigned char fix (python-pillow#1814) since the call to array.array was in another place, the roundtrip was no longer equivalent. That was a minor change, but the revised test wouldn't pass because saving an image with one custom qtable automatically adds a second to it by the call to jpeg_set_defaults. With 1 or >2 custom tables, there is extra work we have to do due to that call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue from using signed char instead of unsigned char. added test