Disable-platform-guessing in setup.py #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cross-compiling (ex on Buildroot) platform guessing is not needed cause the environment is correctly built externally. This patch adds an option to disable platform guessing on Linux.
|
@angeloc Could you check that this still works for you. |
|
Changes Unknown when pulling dd6de1a on wiredfool:pr_1861 into * on python-pillow:master*. |
|
@wiredfool : Tested on Buildroot, it works like a charm! Please merge! |
|
@wiredfool: I would really have python-pillow included in buildroot, is there any possibility that a minor release will be released with this fix included? |
|
Unlikely before the scheduled release at the beginning of July, unless we have another issue that it can piggyback on. We generally only do point releases for security bugs or regressions, and this doesn't hit that criteria. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a bit of a refactor of #1861 + docs.