Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: fix C90 compilation error for Tcl / Tk stuff #2033

Merged
merged 1 commit into from Aug 6, 2016

Conversation

matthew-brett
Copy link
Contributor

@matthew-brett matthew-brett commented Jul 17, 2016

Tk stuff introduced a warning about compilation of new Tk code, and thence an error. Slight rephrase of C code to fix.

Should fix
#2017

New Tk code that picks up libraries at run-time causes complaints and errors;
fix.

See: python-pillow#2017
@wiredfool
Copy link
Member

Thanks @matthew-brett. @mzbqhbc, @Fak3 Does this fix your issue?

@wiredfool wiredfool added this to the 3.3.1 milestone Jul 17, 2016
matthew-brett added a commit to matthew-brett/matplotlib that referenced this pull request Jul 18, 2016
Same code in Pillow generating a compile error on OpenSUSE:

python-pillow/Pillow#2017

Apply same fix, by defining variables before use:

python-pillow/Pillow#2033
@wiredfool
Copy link
Member

wiredfool commented Aug 6, 2016

Ping: @mzbqhbc, @Fak3 Does this fix your issue?

apart from that, LGTM

@Fak3
Copy link

Fak3 commented Aug 6, 2016

@wiredfool yes, i just installed that branch successfully

@wiredfool wiredfool merged commit 370d3f8 into python-pillow:master Aug 6, 2016
@wiredfool
Copy link
Member

Great, Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants