TiffImagePlugin: __next is not updated properly #2047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this is not enough. I still have |
|
Can you share the other image where you're getting similar behavior? |
|
I've added another test image that triggers the bug. I still have no idea how to fix it. |
|
The test case is here: 25804cc |
|
The general problem illustrated by the second test in this PR is that once you load the last frame in the image, the file is closed, so you can't go back and reload earlier frames. It's a general design decision, and one that probably needs to be looked at in concert with the other file closing issues. |
Closed
|
The test in this PR now passes in Pillow 4.1. |
|
Should the tests be included in the test suite? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
ValueError: seek of closed filein the attached test case