Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated lcms2 to 2.8 #2088

Closed
wants to merge 1 commit into from
Closed

Conversation

radarhere
Copy link
Member

No description provided.

@radarhere
Copy link
Member Author

So this has failed because the SourceForge URL isn't working. However, at least some, if not all, of the SourceForge URLs in config.py aren't working either for me. Any thoughts from anyone?

@wiredfool
Copy link
Member

We should pull from the depends repo instead, and have docs for refreshing and verifying.

@hugovk
Copy link
Member

hugovk commented Aug 22, 2016

Searching the web for "iweb.dl.sourceforge.net" gives other file URLs which also now 404.

Some if not all of these SourceForge files are already in https://github.com/python-pillow/pillow-depends. Should we use those instead?

@wiredfool
Copy link
Member

iweb is a sourceforge mirror that worked when these were first added, but may need updating now. I believe that sourceforge has undergone some major changes recently(possibly for the better), so it's not surprising that the mirroring has shifted.

It would probably make sense to check and consolidate so that we have at least one known good source in our depends repo.

@hugovk
Copy link
Member

hugovk commented Aug 29, 2016

See PR #2095.

@aclark4life
Copy link
Member

Do we have a label for "Some checks were not successful"? 😄 (appveyor)

@radarhere
Copy link
Member Author

I've rebased this after the merge of #2095

It requires lcms2 2.8 to be present. So python-pillow/pillow-depends#15 will need to be merged before this can pass. I have left the 2.7 zip present there as well, so that unrelated Pillow PRs are not affected.

@radarhere
Copy link
Member Author

I merged the pillow-depends PR, but this PR is still failing.

@radarhere radarhere closed this Dec 11, 2016
@radarhere radarhere deleted the lcms2 branch December 11, 2016 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants