Convert DPI to ints when saving as JPEG #2102
Conversation
| @@ -593,7 +593,7 @@ def _save(im, fp, filename): | |||
|
|
|||
| info = im.encoderinfo | |||
|
|
|||
| dpi = info.get("dpi", (0, 0)) | |||
| dpi = [int(x) for x in info.get("dpi", (0, 0))] | |||
There was a problem hiding this comment.
I would round to nearest integer.
Ideally it would round to the nearest integer dpi or the nearest integer "dot per centimeter" whatever is closest.
There was a problem hiding this comment.
Is this essentially what you're referring to? https://github.com/python-pillow/Pillow/blob/master/PIL/BmpImagePlugin.py#L104
There was a problem hiding this comment.
@radarhere I wouldn't worry about meters/cm, but rounding seems reasonable.
There was a problem hiding this comment.
So the rounding to the nearest integer that I'm already doing? Apologies if confused.
There was a problem hiding this comment.
>>> int(3.9)
3
>>> int(round(3.9))
4
<aside> what a lovely bikeshed we've got here </aside>
There was a problem hiding this comment.
@wiredfool thanks. updated the PR.
Fixes #2077. Alternative to PR #2084.
Uses the test suggested in the issue.