Added append_images parameter to GIF saving #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
append_images
branch
2 times, most recently
from
cc011b1
to
6634729
Compare
|
The palette is completely broken for all the frames but the first one. |
|
@wodim can you provide files/code to allow me to replicate? |
|
Just take a few png files of the same size (pictures of stuff, not simple pngs of only one colour) and try to save them as a GIF. |
radarhere
force-pushed
the
append_images
branch
from
6634729
to
1d74a0e
Compare
radarhere
force-pushed
the
append_images
branch
from
1d74a0e
to
9d56205
Compare
radarhere
force-pushed
the
append_images
branch
from
9d56205
to
b346ed3
Compare
|
Okay, I've made changes to this PR. Please try again. |
|
Thank you very much, this seems to work correctly. |
Closed
kkopachev
added a commit
to kkopachev/thumbor
that referenced
this pull request
Dec 13, 2016
They changed number of elements output in getdata function: python-pillow/Pillow#2103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to resolve #2098
The request was to create an animated GIF from scratch. This change is a bit more general, providing a mechanism to add different images when saving a GIF. Usage is
The
append_imagesparameter will not be used unlesssave_allis true.Please provide any feedback.