Allow pathlib.Path in Image.open on Python 2.7 #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Sep 14, 2016
| @@ -2279,10 +2279,14 @@ def open(fp, mode="r"): | |||
| filename = "" | |||
| if isPath(fp): | |||
| filename = fp | |||
| elif sys.version_info >= (3, 4): | |||
There was a problem hiding this comment.
Before, the pathlib stuff was only run when isPath(fp) is False (and Python >= 3.4).
Now, it's always run, whether isPath(fp) is False or True.
Should the try/except be put in an else case, so it's only run when isPath(fp) is False?
There was a problem hiding this comment.
To maintain consistency with the previous behaviour you are totally right. This is now done.
Although the pathlib backport for Python 2.7 may be deprecated: https://pypi.python.org/pypi/pathlib/ It is still used by many projects. Therefore, changing to a Try/Except pattern for checking for pathlib is not any more obtrusive that the current >= Python 3.4 check and allows users to use the backport without issue.
patricksnape
force-pushed
the
allow_pathlib_py2
branch
from
11d2e4e
to
e981c41
Compare
|
@hugovk Thanks for the review - that update has been made (force pushed) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
pathlib.PathforImage.openon Python 2.7Although the pathlib backport for Python 2.7 may be deprecated:
https://pypi.python.org/pypi/pathlib/
It is still used by many projects. Therefore, changing to a
Try/Except pattern for checking for pathlib is not any more
obtrusive that the current >= Python 3.4 check and allows users
to use the backport without issue.