Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Use more Pythonic super().__init__() instead of calling parent class directly #2198
The MRO is still explicit. It is defined on the
I suppose that is subjective. As someone who uses
The MRO of super() is controlled at runtime, the MRO of the explicit parent call is determined when the code is authored. Those are two different things. This is covered in super considered super.
Certainly, but this is desired behaviour. Python is very flexible language and there should be a way to insert your class in the middle of MRO. Super allows this.
I have no problem doing the work, I like contributing. So I feel plenty inspired. I just don't want to waste everyone's time (including my own) if it is known ahead of time that it will be rejected. FWIW, I still think using
4 times, most recently
Dec 16, 2017
@@ Coverage Diff @@ ## master #2198 +/- ## ========================================= - Coverage 83.21% 80.6% -2.62% ========================================= Files 169 164 -5 Lines 23507 22493 -1014 Branches 2795 2795 ========================================= - Hits 19562 18130 -1432 - Misses 3945 4363 +418