Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TextIOWrapper.detach() instead of NoCloseStream #2214

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Use TextIOWrapper.detach() instead of NoCloseStream #2214

merged 1 commit into from
Sep 26, 2018

Conversation

jdufresne
Copy link
Contributor

@jdufresne jdufresne commented Nov 11, 2016

Usage and this pattern is discussed in Python bug: https://bugs.python.org/issue21363

detach() docs

@jdufresne
Copy link
Contributor Author

Rebased on latest mater.

@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

Merging #2214 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2214      +/-   ##
==========================================
+ Coverage   83.21%   83.28%   +0.06%     
==========================================
  Files         169      168       -1     
  Lines       23507    22618     -889     
  Branches     2795     2795              
==========================================
- Hits        19562    18838     -724     
+ Misses       3945     3780     -165
Impacted Files Coverage Δ
src/PIL/EpsImagePlugin.py 89.22% <100%> (-0.14%) ⬇️
src/libImaging/File.c 76% <0%> (-8.62%) ⬇️
src/PIL/PngImagePlugin.py 89.97% <0%> (-0.21%) ⬇️
src/_webp.c 80.62% <0%> (-0.13%) ⬇️
src/PIL/JpegImagePlugin.py 91.41% <0%> (-0.11%) ⬇️
src/libImaging/Unpack.c 96.67% <0%> (-0.07%) ⬇️
src/PIL/Image.py 91.09% <0%> (-0.02%) ⬇️
src/PIL/WalImageFile.py 0% <0%> (ø) ⬆️
src/PIL/XpmImagePlugin.py 89.47% <0%> (ø) ⬆️
src/PIL/WmfImagePlugin.py 95.31% <0%> (ø) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca850a6...d2851bb. Read the comment docs.

@hugovk hugovk merged commit 9e54c14 into python-pillow:master Sep 26, 2018
@jdufresne jdufresne deleted the eps-text-wrapper branch March 17, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants