Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved iCCP chunk before PLTE chunk when saving as PNG #2347

Merged
merged 3 commits into from
Jan 26, 2017

Conversation

radarhere
Copy link
Member

Fixes #2201

@homm
Copy link
Member

homm commented Jan 8, 2017

Tests?

@radarhere radarhere force-pushed the icc_profile branch 2 times, most recently from f742815 to 2f8d139 Compare January 15, 2017 06:37
@radarhere
Copy link
Member Author

Okay, I've added a test.

@wiredfool
Copy link
Member

So with this patch are we handling the ordering correctly for all of the chunks now?

@radarhere radarhere force-pushed the icc_profile branch 2 times, most recently from b6fa5c0 to cf610e5 Compare January 21, 2017 04:37
@radarhere
Copy link
Member Author

For all of the chunks that are written specifically, yes, the iCCP change covers it.

However, there is writing of arbitrary chunks at https://github.com/python-pillow/Pillow/blob/master/PIL/PngImagePlugin.py#L762. So I have added another commit to this PR to restrict that process to writing allowed chunk names, in the correct order, that are not specifically written elsewhere in the file,.

@wiredfool wiredfool merged commit 2df28a6 into python-pillow:master Jan 26, 2017
@radarhere radarhere deleted the icc_profile branch January 27, 2017 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants