Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[etc] Fix built-in name. #2612

Merged
merged 2 commits into from Jul 6, 2017
Merged

[etc] Fix built-in name. #2612

merged 2 commits into from Jul 6, 2017

Conversation

kijeong
Copy link
Contributor

@kijeong kijeong commented Jul 6, 2017

Changes proposed in this pull request:

  • Fix the built-in name "dict" to "dict_" in PIL/PdfImagePlugin.py
    It can be seen an error when: python -c "from Cython.Build import cythonize; cythonize(['PIL/PdfImagePlugin.py'])"

@hugovk
Copy link
Member

hugovk commented Jul 6, 2017

I agree builtin names should be avoided, and perhaps dictionary is better than dict_.

(There's a chance someone may already be calling this and naming dict as the parameter, but they shouldn't be, as _obj is an internal.)

@kijeong
Copy link
Contributor Author

kijeong commented Jul 6, 2017

I agree that 'dictionary' as name is better for PDF dictionary objects parameter.

@wiredfool wiredfool merged commit 912b0f0 into python-pillow:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants