Fillcolor parameter for Transform #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiredfool
force-pushed
the
issue_2837
branch
from
f6a9f48
to
68b960c
Compare
radarhere
reviewed
Nov 13, 2017
Tests/test_image_transform.py
Outdated
| w*2, h*2), | ||
| Image.BILINEAR, | ||
| fill = 'red') | ||
| transformed.show() |
There was a problem hiding this comment.
You've left debugging code in?
There was a problem hiding this comment.
and two copies of the same test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2837 .
Changes proposed in this pull request:
_imaging.transform2rather than hardwiring it to true.Note: This extends the api and retains the currently mostly ignored
fillparameter. Thisfillparameter is currently passed into the ImageTransformHandler api, which has user supplied code that we don't control. If we repurpose that parameter, we risk breaking existing code.