Update docs to reflect that font can be loaded from a stream, not jus… #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiredfool
reviewed
Nov 19, 2017
PIL/ImageFont.py
Outdated
| This function loads a font object from the given file, and creates | ||
| a font object for a font of the given size. | ||
| Load a TrueType or OpenType font from a file or stream, and create | ||
| a font object. |
There was a problem hiding this comment.
I think we can just change this instance to file like object, and leave the next one as file.
There was a problem hiding this comment.
Nitpick: file-like object for both.
wiredfool
reviewed
Nov 19, 2017
PIL/ImageFont.py
Outdated
| is not found in this filename, the loader also looks in | ||
| Windows :file:`fonts/` directory. | ||
| :param font: A filename or binary stream containing a TrueType font. | ||
| Under Windows, if the file is not found in this filename, |
There was a problem hiding this comment.
Here I think we should change binary stream to file like object.
|
Changed the wording as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t by filename
I want to load my font from an io.BytesIO stream. It turns out that ImageFont already supports this, but the docs weren't clear on that matter.
Fixes # .
Changes proposed in this pull request: