Test 3.7-dev ahead of 3.7.0's expected 2018-06-15 release #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'd catch the platform.dist thing, because setup.py would fail, and the package wouldn't get built. |
|
It didn't fail in this PR build, at least my branch passed before platform.dist was removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.7.0 is due out on 2018-06-15, or after two Pillow releases.
https://www.python.org/dev/peps/pep-0537/#schedule
One 3.7 incompatibility has been caught in #2869, but shall we start testing against 3.7-dev already to make sure nothing else sneaks in there before it's out?
We don't test setup.py, so this doesn't didn't actually catch
platform.dist's removal, but the good news is all the existing tests pass.