Make PngImagePlugin.add_text() zip argument type bool #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always used as a bool, but was previously defined as 0/1. Use modern idiomatic Python by using the bool type for bool arguments.
wiredfool
reviewed
Dec 19, 2017
| @@ -249,7 +249,7 @@ def add_itxt(self, key, value, lang="", tkey="", zip=False): | |||
| self.add(b"iTXt", key + b"\0\0\0" + lang + b"\0" + tkey + b"\0" + | |||
| value) | |||
|
|
|||
| def add_text(self, key, value, zip=0): | |||
| def add_text(self, key, value, zip=False): | |||
There was a problem hiding this comment.
As an aside, this is a really badly named parameter, as it shadows a builtin. However, since it's (nominally) a named parameter in a public interface, changing it is potentially going to cause more pain than it's worth.
There was a problem hiding this comment.
I agree, but I wasn't attempting to change the public interface. I agree, that may be worthwhile to avoid the builtin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always used as a
bool, but was previously defined as 0/1. Use modern idiomatic Python by using thebooltype forboolarguments.