Fix collections ABCs DeprecationWarning in Python 3.7 #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
changed the title
|
This adds lines which are covered by tests. Coverage should increase. Codecov coverage increased. Coveralls coverage decreased, probably due to #2934. |
hugovk
force-pushed
the
collections.abc-deprecationwarning
branch
from
e1e0a42
to
3dbd4fb
Compare
|
Re-built, coverage now good after #2934 (comment). |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3122.
Changes proposed in this pull request:
collections.abc(new in Python 3.3) overcollectionsfor abstract base classescollections.abcwill no longer be exposed in the regularcollectionsmodule. This will help create a clearer distinction between the concrete classes and the abstract base classes."