Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent DPI rounding #3709

Merged
merged 1 commit into from
Mar 30, 2019
Merged

Consistent DPI rounding #3709

merged 1 commit into from
Mar 30, 2019

Conversation

radarhere
Copy link
Member

Resolves #3323

Whether or not DPI is rounded, or how it is rounded, is inconsistent between image formats.

  • JPEG does not round on load, and rounds to the nearest integer on save
  • BMP rounds up on load, rounds down on save
  • PNG rounds to the nearest integer on load and save
  • TIFF does not round on load or save
  • WMF rounds down on load

This PR changes all to round to the nearest integer.

@radarhere radarhere changed the title Round DPI to integers Consistent DPI rounding Mar 11, 2019
@radarhere radarhere mentioned this pull request Mar 11, 2019
Closed
@hugovk
Copy link
Member

hugovk commented Mar 28, 2019

Should this include tests?

@radarhere
Copy link
Member Author

I've added tests. Some of the added images are hex edited.

@hugovk hugovk merged commit 2fdd3e1 into python-pillow:master Mar 30, 2019
@radarhere radarhere deleted the dpi branch March 30, 2019 11:12
@radarhere radarhere mentioned this pull request Aug 8, 2019
Merged
@radarhere radarhere mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radarhere @hugovk