Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added explicit braces #3937

Merged
merged 1 commit into from Jul 3, 2019
Merged

Added explicit braces #3937

merged 1 commit into from Jul 3, 2019

Conversation

radarhere
Copy link
Member

@hugovk
Copy link
Member

hugovk commented Jul 2, 2019

Yep, it makes sense to always include braces, even for one-liners, to prevent bugs like this:

if (x)
    f1();
+   f2();

No bug:

if (x) {
    f1();
+   f2();
}

Let's start adding them for new code.

hugovk
hugovk approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after the release is out.

@hugovk hugovk mentioned this pull request Jul 2, 2019
Closed
@hugovk hugovk merged commit 50693f8 into python-pillow:master Jul 3, 2019
@radarhere radarhere deleted the warnings branch July 3, 2019 12:13
@radarhere radarhere mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radarhere @hugovk