Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Codecov's GitHub Action #4216

Merged
merged 2 commits into from Dec 2, 2019
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 20, 2019

Changes proposed in this pull request:

@hugovk hugovk added the Build label Nov 20, 2019
@hugovk
Copy link
Member Author

hugovk commented Nov 20, 2019

Yeah, this doesn't work, for the same reason we added the token to .codecov.yml in the first place: GHA won't allow forks access to secrets, namely secrets.CODECOV_TOKEN.

So there's no GHA coverage here (yet, but all GHA jobs have finished):

Specific issue at Codecov GitHub Action:

General issue at GitHub Community:

Let's see what happens with the token re-added.

@nulano
Copy link
Contributor

nulano commented Nov 20, 2019

How about putting the token in the .yml files (hopefully temporarily)? I think using the GitHub action is cleaner; coverage currently doesn't work on Windows, and the Linux builds are received as 'Untitled' anyway.

@hugovk
Copy link
Member Author

hugovk commented Nov 20, 2019

Yes, let's give it a go. Bullet point 3 will still be a problem, but the other bits are an improvement over the current situation.

@hugovk hugovk merged commit 4e125fd into python-pillow:master Dec 2, 2019
@hugovk hugovk deleted the gha-codecov-action branch December 2, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants