Fixed UNDEFINED TIFF tag of length 0 being changed in roundtrip #5426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would maintain that this should not be the case, so this PR fixes that.
What is special about this tag is that it is UNDEFINED with length 0.
Pillow/src/PIL/TiffTags.py
Line 192 in ab8955b
The value of an UNDEFINED tag is always turned into a list in
_setitem
- meaning that if it is already a sequence, it gets wrapped again.Pillow/src/PIL/TiffImagePlugin.py
Lines 566 to 569 in ab8955b
And because the length is 0, at the end of
_setitem
it isn't unwrapped.Pillow/src/PIL/TiffImagePlugin.py
Lines 584 to 608 in ab8955b
While I think this problem is worth fixing in it's own right, this does also resolve #2278. So if this is merged first, then #5425 becomes just about tidying up the tag value by turning it from a tuple into a bytestring.