Do not round dimensions when saving PDF #5459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3565
The issue reports that the
resolution
argument when saving PDFs does not appear correctly when opening the resulting PDF in commercial software.Crunching the numbers, this is because of rounding that is used by Pillow when saving a PDF.
Pillow/src/PIL/PdfImagePlugin.py
Lines 202 to 217 in 676f4db
Searching for whether rounding needs to be used, I'm able to use GIMP to export a PDF with MediaBox float values, and I see an example at https://books.google.com.au/books?id=JJN_BAAAQBAJ&pg=PA102#v=onepage&q&f=false. As for
page_contents
, I see float values on page 287 of https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/pdf_reference_archives/PDFReference.pdfSo this PR removes the rounding.