Fix build with libraqm < 0.7.0 #5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc's cpp doesn't short-circuit when RAQM_VERSION_ATLEAST is undefined so building fails on systems with old libraqm (e.g. Debian 10 for raspberry pi where wheels w/libraqm support may not be available). RAQM_VERSION_ATLEAST was introduced with 0.7.0, so the test is effectively equivalent.
radarhere
approved these changes
May 3, 2021
|
Yes, I see that the Debian package does have an older version - https://packages.debian.org/buster/libraqm-dev |
nulano
approved these changes
May 3, 2021
nulano
reviewed
May 3, 2021
Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc's cpp doesn't short-circuit when RAQM_VERSION_ATLEAST is undefined
so building fails on systems with old libraqm (e.g. Debian 10 for
raspberry pi where wheels w/libraqm support may not be available).
RAQM_VERSION_ATLEAST was introduced with 0.7.0, so the test is
effectively equivalent.