-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept any path-like object for Image.{open,save}
and truetype
, not just pathlib.Path
#5621
Conversation
Image.{open,save}
and truetype
, not just pathlib.Path
Image.{open,save}
and truetype
, not just pathlib.Path
Are you saying that you've found bugs, separate to the path-like object changes? Could you provide some more detail about this? |
@radarhere: Any idea why that Windows test is failing? |
It's an intermittent failure on master. Nothing to do with your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs suggestion: use "file path" or "path" instead of "filepath" which isn't used much:
…t just `pathlib.Path` Also tries to fix some bugs where PIL will crash in case of binary paths, by using `os.fsdecode`.
By @hugovk. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
I've made a suggestion for this over at https://github.com/ntninja/Pillow/pull/2 |
I think we've resolved this now. Can we merge this then? |
Also tries to fix some bugs where PIL will crash in case of binary paths, by using
os.fsdecode
.Changes proposed in this pull request:
str
,bytes
andpathlib.Path