Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: 'brew install openjpeg' for JPEG2000 support #6065

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 17, 2022

Shall we include JPEG2000 as well?


Whilst we're here, a line or two down we tell the user to pip install Pillow from PyPI, or instead build from source:

Now install Pillow with::

    python3 -m pip install --upgrade pip
    python3 -m pip install --upgrade Pillow

or from within the uncompressed source directory::

    python3 -m pip install .

But this is the section on Building from source, we already had the Basic installation near the top of the page.

Shall we change it to this?

Now install from within the uncompressed source directory::::

    python3 -m pip install --upgrade pip
    python3 -m pip install .

@radarhere
Copy link
Member

Good point about building from source.

But there are three other instances where we tell people to pip install --upgrade Pillow when "Building from source", and I wonder if it's an extra step to tell them to download the source code in each section. How about using --no-binary :all: instead? See PR #6066

@radarhere radarhere added the automerge Automatically merge PRs that are ready label Feb 17, 2022
@mergify mergify bot merged commit 29b7030 into python-pillow:main Feb 17, 2022
@hugovk hugovk deleted the mac-install-openjpeg branch February 18, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PRs that are ready Documentation macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants