Search for libfribidi.dylib in /usr/local/lib #6182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently created python-pillow/pillow-wheels#281, to test fribidi on macOS. It became apparent that while /usr/local/lib/libfribidi.dylib was present on the system, it was not found by Pillow. My immediate solution to this was just to create a link to libfribidi.dylib in the current directory.
However, if the macOS environment being used for pillow-wheels is normal, then it is conceivable that this problem might occur for end users. For example, perhaps this is the solution to #6175? So I'm creating this PR to explicitly search /usr/local/lib.
If you would like some more information, here is a run of the pillow-wheels PR without the link, so that you can see Pillow fail to find libfribid, and here is a run of the PR without the link and with the changes from this PR, so you can see it work.