Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSSF Best Practices badge #6597

Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 19, 2022

I started filling out the sections at https://bestpractices.coreinfrastructure.org/en/projects/6331 and we're currently at 76%:

image

Still some more to check, but we can already add the badge:

image

Preview

README

image

https://github.com/hugovk/Pillow/tree/add-openssf-best-practices-badge

Docs

image

https://pillow--6597.org.readthedocs.build/en/6597/

README.md Outdated
@@ -74,6 +74,9 @@ As of 2019, Pillow development is
<a href="https://pypi.org/project/Pillow/"><img
alt="Number of PyPI downloads"
src="https://img.shields.io/pypi/dm/pillow.svg"></a>
<a href="https://bestpractices.coreinfrastructure.org/projects/6331"><img
alt="CII Best Practices"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alt="CII Best Practices"
alt="openssf best practices"

I think the alt text should reflect what is otherwise seen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, looks like they've not updated the template at https://bestpractices.coreinfrastructure.org/en/projects/6331 since they renamed:

This project was formerly known as the Core Infrastructure Initiative (CII) Best Practices badge. and was originally developed under the CII. It is now part of the OpenSSF Best Practices Working Group (WG). The OpenSSF is a foundation of the Linux Foundation (LF). The project was formally renamed from "CII Best Practices badge" on 2021-12-24.

I'll send them feedback, and also update the alts to use proper caps.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/index.rst Outdated
@@ -69,6 +69,10 @@ Pillow for enterprise is available via the Tidelift Subscription. `Learn more <h
:target: https://pypi.org/project/Pillow/
:alt: Number of PyPI downloads

.. image:: https://bestpractices.coreinfrastructure.org/projects/6331/badge
:target: https://bestpractices.coreinfrastructure.org/projects/6331
:alt: CII Best Practices
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:alt: CII Best Practices
:alt: openssf best practices

@hugovk hugovk force-pushed the add-openssf-best-practices-badge branch from 602343a to 1bdf6ef Compare September 19, 2022 07:37
@radarhere radarhere merged commit c464a11 into python-pillow:main Sep 19, 2022
@hugovk hugovk deleted the add-openssf-best-practices-badge branch September 19, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants