Ensure dependencies are installed when building docs #6612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Sep 23, 2022
Makefile
Outdated
Comment on lines
20
to
21
| python3 -c "import PIL" > /dev/null 2>&1 || python3 -m pip install . | ||
| python3 -c "import olefile" > /dev/null 2>&1 || python3 -m pip install olefile |
There was a problem hiding this comment.
We're building Pillow anyway, shall we just use the docs extra?
Suggested change
| python3 -c "import PIL" > /dev/null 2>&1 || python3 -m pip install . | |
| python3 -c "import olefile" > /dev/null 2>&1 || python3 -m pip install olefile | |
| python3 -c "import PIL" > /dev/null 2>&1 || python3 -m pip install ".[docs]" |
There was a problem hiding this comment.
If Pillow was already installed, but olefile wasn't, your version wouldn't install it. Unless you'd like to add olefile to the docs/Makefile install command?
There was a problem hiding this comment.
Yes, makes more sense to move it to docs/Makefile.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the sphinx requirements from
Pillow/.github/workflows/test.yml
Line 102 in af8260e
Pillow/docs/Makefile
Lines 45 to 47 in af8260e
make doccan ensure that all of the dependencies are installed.Also ensures that Pillow and olefile are installed, two more requirements for building the docs.