Clean up tests (simplified) #6865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Jan 7, 2023
Tests/test_image_resize.py
Outdated
| @@ -57,13 +57,13 @@ def test_convolution_modes(self): | |||
| Image.Resampling.LANCZOS, | |||
| ), | |||
| ) | |||
| def test_reduce_filters(self, resample): | |||
| r = self.resize(hopper("RGB"), (15, 12), resample) | |||
There was a problem hiding this comment.
Why is 'resampling_filter' clearer? 'resample' is the name of the variable when the core resize operation is called in Image.py
Line 2192 in 86634b8
There was a problem hiding this comment.
Since your clear intention to just get part of #6653 merged, I'll save this change for that PR, and merge the rest.
There was a problem hiding this comment.
Because "resample" is an action, while "resampling filter" is an object. The thing being passed is (an ID for) a resampling filter, not a "resample". It doesn't work to say that "resample" is the type of the thing being passed either, because the type of the thing being passed is a Resampling enum item.
radarhere
force-pushed
the
test_cleanup_s
branch
from
2247c8d
to
04199b6
Compare
radarhere
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is commits 2-6 from #6653.