Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow writing IFDRational to BYTE tag #6890

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Allow writing IFDRational to BYTE tag #6890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions Tests/test_file_tiff_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,15 @@ def test_writing_other_types_to_ascii(value, expected, tmp_path):
assert reloaded.tag_v2[271] == expected


def test_writing_int_to_bytes(tmp_path):
@pytest.mark.parametrize("value", (1, IFDRational(1)))
def test_writing_other_types_to_bytes(value, tmp_path):
im = hopper()
info = TiffImagePlugin.ImageFileDirectory_v2()

tag = TiffTags.TAGS_V2[700]
assert tag.type == TiffTags.BYTE

info[700] = 1
info[700] = value

out = str(tmp_path / "temp.tiff")
im.save(out, tiffinfo=info)
Expand Down
2 changes: 2 additions & 0 deletions src/PIL/TiffImagePlugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,8 @@ def load_byte(self, data, legacy_api=True):

@_register_writer(1) # Basic type, except for the legacy API.
def write_byte(self, data):
if isinstance(data, IFDRational):
data = int(data)
if isinstance(data, int):
data = bytes((data,))
return data
Expand Down