Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release checklist: macOS/Linux artifact is called 'wheels' #7467

Merged
merged 1 commit into from Oct 15, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 15, 2023

Noticed during #7348, helps #7390.

Windows

The Windows instructions are correct, it's artifact is "dist-x.y.z":

for /f "tokens=3 delims=/" %%a in ("${{ github.ref }}") do echo dist=dist-%%a >> %GITHUB_OUTPUT%

- name: Upload wheel
uses: actions/upload-artifact@v3
if: "github.event_name != 'pull_request'"
with:
name: ${{ steps.wheel.outputs.dist }}
path: "*.whl"

macOS/Linux

But macOS/Linux is simply "wheels":

uses: ./.github/workflows/wheels-macos.yml
with:
artifacts-name: "wheels"

uses: ./.github/workflows/wheels-linux.yml
with:
artifacts-name: "wheels"

- uses: actions/upload-artifact@v3
with:
name: ${{ inputs.artifacts-name }}
path: wheelhouse/*.whl

- uses: actions/upload-artifact@v3
with:
name: ${{ inputs.artifacts-name }}
path: wheelhouse/*.whl

@radarhere radarhere merged commit 0853adc into python-pillow:main Oct 15, 2023
53 checks passed
@hugovk hugovk deleted the update-release-checklist branch October 16, 2023 04:48
@hugovk hugovk added the Release label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants