Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip AppVeyor builds for irrelevant files #7909

Merged
merged 1 commit into from Mar 27, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 27, 2024

Similar to GitHub Actions, we can skip AppVeyor builds when irrelevant files are changed.

For example, we don't need to test Windows for changes that are exclusively docs, or cibuildwheel.

This is based on GHA's test-windows.yml:

paths-ignore:
- ".github/workflows/docs.yml"
- ".github/workflows/wheels*"
- ".gitmodules"
- "docs/**"
- "wheels/**"

Except widened one skip to the whole .github directory.

Docs: https://www.appveyor.com/docs/how-to/filtering-commits/#commit-files-github-and-bitbucket-only

skip_commits.files allows skipping AppVeyor build if all of the files modified in push’s head commit match any of the file matching rules.

I've not tried this out before on AppVeyor. We only have two jobs on AppVeyor, and they run in serial (max parallel runners=1), but it's not causing a particular bottleneck compared to the big GHA matrix. However, one minor annoyance, in PRs like #7905, we skip the regular tests on GHA, but AppVeyor still runs, meaning we get a code coverage report of ~50%.

.appveyor.yml Outdated Show resolved Hide resolved
@hugovk hugovk merged commit 59cb1d7 into python-pillow:main Mar 27, 2024
56 checks passed
@hugovk hugovk deleted the appveyor-skip branch March 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants