New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected check for libtiff feature #8000

Merged

hugovk merged 2 commits into python-pillow:main from radarhere:libtiff

Apr 22, 2024

Member

radarhere commented Apr 22, 2024

Follow up to #7975

I missed a place where WRITE_LIBTIFF is assigned directly in the tests, rather than using monkeypatch instead.
In parametrizing tests, I forgot that libtiff_support_custom_tags is only present if libtiff support is present. While @skip_unless_feature("libtiff") is there on this test file, the parametrize conditions are still evaluated, so if libtiff support is absent, this causes an error. I've used getattr to fix this.

radarhere added 2 commits

April 22, 2024 18:30


          support_custom_tags attribute is not present if libtiff is not supported

c7bb152


          Parametrized test

0df8796

radarhere added TIFF Testing labels

nulano approved these changes

View reviewed changes

hugovk merged commit 1c21cd4 into python-pillow:main

54 checks passed

radarhere deleted the libtiff branch

April 22, 2024 21:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment