Allow optional output directory for building #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t dist directory is created if no output is passed
radoering
reviewed
Nov 24, 2022
AdamWRichardson
requested review from
finswimmer and
radoering
and removed request for
finswimmer and
radoering
2 tasks
radoering
requested changes
Jan 7, 2023
radoering
approved these changes
Jan 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possbile for the builder factory class to accept an optional output directory when building packages. This builder factory is used by the command line and if this is accepted I would like to add an extra option to the command line to allow placing build artifacts in a directory other than
dist.Of course I am happy to take comments and feedback.
Relates-to: python-poetry/poetry#3586