Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry build -o (was: allow configuring "dist" folder during build) #3586

Closed
Kaiser1989 opened this issue Jan 18, 2021 · 9 comments · Fixed by #8828
Closed

poetry build -o (was: allow configuring "dist" folder during build) #3586

Kaiser1989 opened this issue Jan 18, 2021 · 9 comments · Fixed by #8828
Labels
area/cli Related to the command line kind/feature Feature requests/implementations

Comments

@Kaiser1989
Copy link

  • [x ] I have searched the issues of this repo and believe that this is not a duplicate.
  • [x ] I have searched the documentation and believe that my question is not covered.

Feature Request

Poetry automatically creates a folder in root called "dist" where it puts all distributions files. Is there a way to change this output folder? If not:

Make "dist" folder configurable, by setting a relative path, e.g. build/distribution. This could be done in pyproject.toml:

[build]
target-dir = "build/distribution"

or as variable in .poetry/config

@Kaiser1989 Kaiser1989 added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Jan 18, 2021
@jwdevantier
Copy link

Anyone found a work-around ?

@aishfenton
Copy link

aishfenton commented Oct 16, 2021

+1 for doing this. Our build environment requires it to be in a build/dist/

@mraxilus
Copy link

This issue also came up in my build environment.

@woutervh
Copy link

It seems the current sdist and wheel builder already support an optional target-directory:

https://github.com/python-poetry/poetry-core/blob/master/src/poetry/core/masonry/builders/sdist.py#L61
https://github.com/python-poetry/poetry-core/blob/master/src/poetry/core/masonry/builders/wheel.py#L52

but they are called without it:
https://github.com/python-poetry/poetry/blob/master/src/poetry/console/commands/build.py#L31

@aabmets
Copy link

aabmets commented Jun 12, 2022

6jey15

@davidfstr
Copy link

davidfstr commented Jun 13, 2022

Why are we not funding this?

@aabmets perhaps you could clarify your comment?


Seems to me the next step to move this issue forward is for someone sufficiently motivated to put together a PR.

P.S. I am not a Poetry maintainer, just a subscriber to this issue. I don't happen to be sufficiently motivated myself to make a PR here.

@Secrus
Copy link
Member

Secrus commented Jun 13, 2022

Right now, we are pushing towards the release of the 1.2 version. The feature mentioned here is not critical for the release. There is also no implementation PR or at least some PoC discussed on our discord server. If someone is interested in adding this, please start a discussion on Poetry discord so the feature can be properly talked through.

@finswimmer
Copy link
Member

I don't think this is useful as a configuration option in the pyproject.toml. But as a command line option for poetry build this looks quite useful.

@neersighted neersighted changed the title Make dist folder configurable poetry build -o (was: allow configuring "dist" folder during build) Oct 11, 2022
@neersighted neersighted added area/cli Related to the command line and removed status/triage This issue needs to be triaged labels Oct 11, 2022
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line kind/feature Feature requests/implementations
Projects
None yet
10 participants