Add an option to set output directory on build #7208
Conversation
|
@Secrus Thanks for doing the frontend for me! I did similar changes locally but didn't know how I should test it so didn't push anything, do you have any thoughts on the testing? |
Secrus
changed the title
Secrus
force-pushed
the
build-output-frontend
branch
from
93c9937
to
234f4b3
Compare
Secrus
force-pushed
the
build-output-frontend
branch
from
234f4b3
to
363fef9
Compare
|
Just so I don't forget it later: This change also requires changes to publishing process, since currently, the source directory for build artifacts is hardcoded in publishing code |
forgot to reply to you. I will probably create a test building one of our fixture projects and test whether it is created in the directory it was told to build in. |
| @@ -31,6 +32,6 @@ def handle(self) -> int: | |||
| ) | |||
|
|
|||
| builder = Builder(self.poetry) | |||
| builder.build(fmt, executable=env.python) | |||
| builder.build(fmt, executable=env.python, target_dir=self.option("output")) | |||
There was a problem hiding this comment.
I haven't tested it, but I'm afraid that now the default behavior would be to use a dist folder relative to the current working directory instead of relative to the pyproject.toml file.
Furthermore target_dir expects Path and not str :)
|
Hello, I saw that poetry-core 1.5.0 was released and I would like to contribute on this if I could/need be. 😄 Best regards |
|
@fd0r feel free to take this over. |
|
Would also love to have this feature. |
|
I didn't have much time to work on this recently, I'll try to free some time to finish this |
|
Superseded by #8828 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Waiting for: python-poetry/poetry-core#527
Resolves: #3586
The
buildcommand has currently no tests, not sure whether to start making them from here or make it a separate task.