Packages always included even if they are not listed in packages

[antazoey]

• Poetry version: Poetry (version 1.5.1)
• Python version: Python: 3.10.11
• OS version and name: 13.4.1 (22F82)
• pyproject.toml: https://github.com/antazoey/ApePay/blob/fix/packages-2/pyproject.toml#L8

• I am on the latest stable Poetry version, installed using a recommended method.
• I have searched the issues of this repo and believe that this is not a duplicate.
• I have consulted the FAQ and blog for any relevant entries or release notes.
• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

So the main issue I am having is that if I don't use a src directory to put my packages in and reference them from there, it will always include modules from my root project that I don't want in the Python build. For example, it always includes both scripts and tests which are not part of the package.

By includes, this is what I mean: If I install my project that has this form and I go to my home directory, and I run:

python -c "import scripts; print(scripts.__path__)"

it will print out the path to the project I installed. So I can import tests and scripts from anywhere on my OS, and I am just trying to exclude that from happening.

The only way I have gotten it to work is to put the actual package first in a src directory and reference it like:

packages = [ { include = "my-package", from = "src" } ]

But really , I was hoping to not have to change the project structure. I don't want to have to create a src directory

I would prefer to do this:

packages = [{ include = "apepay" }]

and have it not include tests/ and scripts/.

I have tried every combo of include and exclude and packages but the only that actually works so far is the src directory.

[trag1c]

Fix the pyproject.toml link

[antazoey]

Fix the pyproject.toml link

It's fixed now, sorry about that

[dimbleby]

what you are describing is already the default behaviour and you don't have to specify packages at all, please close.

(I suspect you are simply in a virtual environment where the sys.path includes the root of your codebase)

[antazoey]

Ok thank you, sorry I guess

[antazoey]

@dimbleby just note, it doesnt happen when I use setup.py and the include / packages field for find_packages(), I wish it behaved similarly

[antazoey]

Like I had this same problem when I did:

find_packages(exclide=["scripts"])

but it was fixed when I did:

    packages=["my-package"],

but I tried the equivalent in Poetry and it did not fix

[antazoey]

I either have to use setup.py and not poetry, or I have to change my project structure in order install in editable mode for my project (and not have other packages appear in my path), unless I am just missing something or there is a bug.

[dimbleby]

you've reopened it, but this is still nothing to do with poetry

the way editable installs work is by creating a .pth file, which causes the directory that it points at to be added to the python sys.path. See https://setuptools.pypa.io/en/latest/userguide/development_mode.html. That's what allows your project to be imported.

so all you are seeing is - as I said - that the root of your repository is in your sys.path.

if you build the wheel you can inspect it and verify that it contains only the files that you expect.

Please close.

[dimbleby]

if this is important to you then not using poetry is the right choice.

I have confirmed that a project using pyproject.toml and any backend chosen from flit, hatch, pdm, and setuptools behaves in the same way as poetry, so you'll want to avoid those too.

[dimbleby]

please read what I wrote: I specified "a project using pyproject.toml" behaves that way. You have - I think rightly - said that you have to use setup.py to avoid this behaviour.

my point is that this is nothing to do with poetry - all backends that I can find, including setuptools, then give the same behaviour

[antazoey]

please read what I wrote: I specified "a project using pyproject.toml" behaves that way. You have - I think rightly - said that you have to use setup.py to avoid this behaviour.

OK, I am sorry.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.