Removing setecho(False) for all shells

[jmaroeder]

Pull Request Check List

• Added tests for changed code.
• Updated documentation for changed code.

Intended to fix #1672. It appears to me that the only thing that the setecho(False) line does is prevent a double echo of the /bin/activate command in zsh.

Example outputs

Example outputs from various shells. Note that the only things actually typed here are the initial poetry shell and the final exit:

fish

$ poetry shell
Spawning shell within <REDACTED>/.venv
$ source <REDACTED>/.venv/bin/activate.fish
$ exit

bash

bash-3.2$ poetry shell
Spawning shell within <REDACTED>/.venv

The default interactive shell is now zsh.
To update your account to use zsh, please run `chsh -s /bin/zsh`.
For more details, please visit https://support.apple.com/kb/HT208050.
bash-3.2$ . <REDACTED>/.venv/bin/activate
(.venv) bash-3.2$ exit

zsh

% poetry shell
Spawning shell within <REDACTED>/.venv
. <REDACTED>/.venv/bin/activate
% . <REDACTED>/.venv/bin/activate
(.venv) % exit

[jmaroeder]

Note that the above tests were performed in MacOS.

[itsthejoker]

I can confirm this fix works for me and makes poetry usable again on fish shell. @sdispater please take a look at this PR -- this fixes #1672 and #1664. Cheers!

[sdispater]

Thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.