Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output option to build and dist-dir option to publish command #8828

Merged
merged 11 commits into from Feb 10, 2024

Conversation

benjamin-callonnec
Copy link
Contributor

@benjamin-callonnec benjamin-callonnec commented Dec 28, 2023

Pull Request Check List

  • Add output option to build command.
  • Add dist-dir option to publish command.

Resolves: #3586

Similar PR: #7208

  • Added tests for changed code.
  • Updated documentation for changed code.

@Secrus
Copy link
Member

Secrus commented Dec 29, 2023

This also requires changes to the publishing setup, since using custom build output would make publishing the built artifacts with Poetry impossible. (This is also where my PR stalled)

@benjamin-callonnec
Copy link
Contributor Author

Thank for the comment @Secrus, I tried to take it into consideration!

@Secrus
Copy link
Member

Secrus commented Jan 27, 2024

Could you rebase and resolve conflicts?

@benjamin-callonnec
Copy link
Contributor Author

Could you rebase and resolve conflicts?

Done!

Secrus
Secrus previously approved these changes Jan 30, 2024
Copy link
Member

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @radoering could you also take a look?

@Secrus Secrus mentioned this pull request Jan 30, 2024
@radoering radoering added the impact/docs Contains or requires documentation changes label Jan 30, 2024
Copy link

github-actions bot commented Jan 30, 2024

Deploy preview for website ready!

✅ Preview
https://website-fsk1rqi48-python-poetry.vercel.app

Built with commit 9c9c143.
This pull request is being automatically deployed with vercel-action

tests/console/commands/test_publish.py Show resolved Hide resolved
option(
"output",
"o",
"Set output directory for build artifacts. Default is `dist`.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, we don't use backticks here (only in the docs), but I do not have strong feelings and did not found a reference for something else so 🤷

@radoering radoering changed the title Add output option to build command. Add output option to build and dist-dir option to publish command Feb 10, 2024
@radoering radoering merged commit b0f46c4 into python-poetry:master Feb 10, 2024
33 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry build -o (was: allow configuring "dist" folder during build)
3 participants