Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate gid parameter to db.xact(...) #12

Closed
jwp opened this issue Nov 18, 2009 · 3 comments
Closed

Deprecate gid parameter to db.xact(...) #12

jwp opened this issue Nov 18, 2009 · 3 comments
Labels

Comments

@jwp
Copy link
Contributor

jwp commented Nov 18, 2009

The gid argument enabled a 2pc transaction. When given a gid, the transaction object required that the prepare() method be used before committing on exit. This was intended to provide an abstraction, but use in any distributed transaction manager is likely to lead to more pain than it's worth. For v1.0, the gid documentation will simply be removed, and in 1.1, we'll probably throw a deprecation warning if it's a provided. Subsequent versions will just throw the TypeError as the feature will not exist.

@jwp
Copy link
Contributor Author

jwp commented Nov 22, 2009

Maybe deprecate all parameters to xact()?

It may be better to just let them set the isolation level using with db.settings():...

@jwp
Copy link
Contributor Author

jwp commented Dec 13, 2009

Leave isolation and mode. They're convenient.

Deprecation of gid= has been noted in v0.9's documentation. Feature will no longer be documented in 1.0, and it will subsequently be removed in 1.1.

@jwp
Copy link
Contributor Author

jwp commented Dec 17, 2009

v1.0 branch has removed the documentation. Deprecation warnings are not being issued at this point. Subsequent bugfix releases may include warnings.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant