Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Facebook to Graph API 3.2 #337

Merged
merged 5 commits into from
Apr 7, 2019
Merged

Update Facebook to Graph API 3.2 #337

merged 5 commits into from
Apr 7, 2019

Conversation

dmpe
Copy link
Contributor

@dmpe dmpe commented Mar 22, 2019 •
edited
Loading

Shall close #279

@dmpe
update facebook to v3.2
df19770 
add profile picture which it can also return
@dmpe
bump to 3.1.1
6e2cda2
@dmpe
Copy link
Contributor Author

dmpe commented Mar 22, 2019 •
edited
Loading

@ibolit @tisdall @omab Hi, please could you test this new facebook update.
It updates Graph API to 3.2 and also adds profile picture in the return callback.

sudo pip3 install git+https://github.com/dmpe/social-core.git@bug/facebook

Thank you

@ibolit
Copy link

ibolit commented Mar 25, 2019

Installing the patch to test it

tisdall
tisdall reviewed Mar 25, 2019
View reviewed changes
social_core/__init__.py Outdated Show resolved Hide resolved
@dmpe
Update facebook.py
4e38944 
Reflect on the feedback provided!
@dmpe
Copy link
Contributor Author

dmpe commented Mar 25, 2019

@tisdall thanks for the feedback!

@tisdall
Copy link

tisdall commented Mar 25, 2019

So fast! :)

I looked through the API docs and I don't see anything mentioned about OAuth in the changelogs so hopefully there's nothing else to change.

@ibolit
Copy link

ibolit commented Mar 25, 2019 •
edited
Loading

@dmpe We have tested it, everything seems to work just fine.

@ibolit
Copy link

ibolit commented Apr 3, 2019

I hate to be a nuisance, but can anyone merge this request?

@dmpe
Copy link
Contributor Author

dmpe commented Apr 3, 2019

cc @omab

@tisdall
Copy link

tisdall commented Apr 3, 2019

To be clear, the current v2.9 API will stop working July 18, 2019 according to https://developers.facebook.com/docs/graph-api/changelog/

@omab omab merged commit 2e85134 into python-social-auth:master Apr 7, 2019
@omab
Copy link
Contributor

omab commented Apr 7, 2019

Thanks!

@dmpe dmpe deleted the bug/facebook branch April 7, 2019 13:34
@omab omab mentioned this pull request May 30, 2019
Closed
@tisdall
Copy link

tisdall commented May 30, 2019

@ibolit @dmpe this is now released

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisdall tisdall tisdall left review comments

@omab omab omab approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade facebook from 2.9 to 3.2
4 participants
@dmpe @ibolit @tisdall @omab