New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passport #1174

Merged
merged 26 commits into from Aug 12, 2018

Conversation

Projects
None yet
4 participants
@code1mountain
Contributor

code1mountain commented Jul 29, 2018

Work in Progress

Added Classes:

  • PassportData
  • PassportFile
  • EncryptedPassportElement
  • EncryptedCredentials
  • PassportElementError*

Added function:

  • set_passport_data_errors

Added passport_data field to message.

Added helper function to generate an url that can be used to request access to telegram passport.

File decryption is not implemented yet. Help wanted.

Added corresponding tests

@jsmnbom

This comment has been minimized.

Show comment
Hide comment
@jsmnbom

jsmnbom Jul 31, 2018

Member

Alright, I've added some basic passport decryption. Mostly just focussed on getting it working for now.
We probably wanna move the actual decryption currently at a09394b#diff-eaefd62d25b87433b035868713d3437aR39 somewhere better.

We might also want to look into implementing all or some of the classes described at https://core.telegram.org/passport.

I also added an example that simply prints all the passport data and fetches the url of files. We definitely need to improve it though.

Member

jsmnbom commented Jul 31, 2018

Alright, I've added some basic passport decryption. Mostly just focussed on getting it working for now.
We probably wanna move the actual decryption currently at a09394b#diff-eaefd62d25b87433b035868713d3437aR39 somewhere better.

We might also want to look into implementing all or some of the classes described at https://core.telegram.org/passport.

I also added an example that simply prints all the passport data and fetches the url of files. We definitely need to improve it though.

@jsmnbom

This comment has been minimized.

Show comment
Hide comment
@jsmnbom

jsmnbom Jul 31, 2018

Member

All in all really good work so far though! :D

Member

jsmnbom commented Jul 31, 2018

All in all really good work so far though! :D

@jsmnbom

This comment has been minimized.

Show comment
Hide comment
@jsmnbom

jsmnbom Aug 10, 2018

Member

Alright, I think we're only missing a couple of tests and a bunch of docs now as far as telegram passport support goes.

Member

jsmnbom commented Aug 10, 2018

Alright, I think we're only missing a couple of tests and a bunch of docs now as far as telegram passport support goes.

@jsmnbom jsmnbom changed the base branch from master to bot-api-4.0 Aug 12, 2018

@jsmnbom jsmnbom merged commit 69b03c5 into python-telegram-bot:bot-api-4.0 Aug 12, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!

jsmnbom added a commit that referenced this pull request Aug 12, 2018

@Eldinnie Eldinnie referenced this pull request Aug 12, 2018

Merged

Bot API 4.0 #1168

37 of 37 tasks complete

jsmnbom added a commit that referenced this pull request Aug 29, 2018

Bot API 4.0 (#1168)
Telegram Passport (#1174):

- Add full support for telegram passport.
    - New types: PassportData, PassportFile, EncryptedPassportElement, EncryptedCredentials, PassportElementError, PassportElementErrorDataField, PassportElementErrorFrontSide, PassportElementErrorReverseSide, PassportElementErrorSelfie, PassportElementErrorFile and PassportElementErrorFiles.
    - New bot method: set_passport_data_errors
    - New filter: Filters.passport_data
    - Field passport_data field on Message
    - PassportData is automagically decrypted when you specify your private key when creating Updater or Bot.
    - PassportFiles is also automagically decrypted as you download/retrieve them.
- See new passportbot.py example for details on how to use, or go to our telegram passport wiki page for more info
- NOTE: Passport decryption requires new dependency `cryptography`.

Inputfile rework (#1184):

- Change how Inputfile is handled internally
- This allows support for specifying the thumbnails of photos and videos using the thumb= argument in the different send_ methods.
- Also allows Bot.send_media_group to actually finally send more than one media.
- Add thumb to Audio, Video and Videonote
- Add Bot.edit_message_media together with InputMediaAnimation, InputMediaAudio, and inputMediaDocument.

Other Bot API 4.0 changes:

- Add forusquare_type to Venue, InlineQueryResultVenue, InputVenueMessageContent, and Bot.send_venue. (#1170)
- Add vCard support by adding vcard field to Contact, InlineQueryResultContact, InputContactMessageContent, and Bot.send_contact. (#1166)
- Support new message entities: CASHTAG and PHONE_NUMBER. (#1179)
    - Cashtag seems to be things like $USD and $GBP, but it seems telegram doesn't currently send them to bots.
    - Phone number also seems to have limited support for now
- Add Bot.send_animation, add width, height, and duration to Animation, and add Filters.animation. (#1172)


Co-authored-by: Jasmin Bom <jsmnbom@gmail.com>
Co-authored-by: code1mountain <32801117+code1mountain@users.noreply.github.com>
Co-authored-by: Eldinnie <pieter.schutz+github@gmail.com>
Co-authored-by: mathefreak1 <mathefreak@hi2.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment