New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple inputfiles in requests #1184

Merged
merged 18 commits into from Aug 12, 2018

Conversation

Projects
None yet
2 participants
@jsmnbom
Member

jsmnbom commented Aug 11, 2018

This allows send_media_group to work properly to upload multiple files.
Also makes the thumb argument of send_* methods work as expected.

Allow multiple inputfiles in requests
This allows send_media_group to work properly to upload multiple files.
Also makes the thumb argument of send_* methods work as expected.

Wanna add some more comments/docs before merging
Tests are also missing.

jsmnbom and others added some commits Aug 11, 2018

Animation (#1172)
* Animation stuff

* Fixed tests

* Fixed tests

* Added InputMediaAnimation

* More Tests

* Fixed Test

* Added Shortcuts

* Added Shortcuts

* Added Filter for animation

* Fixed Test

* Fixed Docstring
Fix tests
Use JSON when not uploading
Use inputfile for other bot methods too

jsmnbom added some commits Aug 12, 2018

Remove thumb from inputmediaphoto
it should never have been there in the first place

@jsmnbom jsmnbom changed the base branch from master to bot-api-4.0 Aug 12, 2018

@jsmnbom jsmnbom merged commit a34efa5 into bot-api-4.0 Aug 12, 2018

1 check passed

Hound No violations found. Woof!

@Eldinnie Eldinnie referenced this pull request Aug 12, 2018

Merged

Bot API 4.0 #1168

37 of 37 tasks complete

@Eldinnie Eldinnie deleted the improve-inputfile branch Aug 20, 2018

jsmnbom added a commit that referenced this pull request Aug 29, 2018

Bot API 4.0 (#1168)
Telegram Passport (#1174):

- Add full support for telegram passport.
    - New types: PassportData, PassportFile, EncryptedPassportElement, EncryptedCredentials, PassportElementError, PassportElementErrorDataField, PassportElementErrorFrontSide, PassportElementErrorReverseSide, PassportElementErrorSelfie, PassportElementErrorFile and PassportElementErrorFiles.
    - New bot method: set_passport_data_errors
    - New filter: Filters.passport_data
    - Field passport_data field on Message
    - PassportData is automagically decrypted when you specify your private key when creating Updater or Bot.
    - PassportFiles is also automagically decrypted as you download/retrieve them.
- See new passportbot.py example for details on how to use, or go to our telegram passport wiki page for more info
- NOTE: Passport decryption requires new dependency `cryptography`.

Inputfile rework (#1184):

- Change how Inputfile is handled internally
- This allows support for specifying the thumbnails of photos and videos using the thumb= argument in the different send_ methods.
- Also allows Bot.send_media_group to actually finally send more than one media.
- Add thumb to Audio, Video and Videonote
- Add Bot.edit_message_media together with InputMediaAnimation, InputMediaAudio, and inputMediaDocument.

Other Bot API 4.0 changes:

- Add forusquare_type to Venue, InlineQueryResultVenue, InputVenueMessageContent, and Bot.send_venue. (#1170)
- Add vCard support by adding vcard field to Contact, InlineQueryResultContact, InputContactMessageContent, and Bot.send_contact. (#1166)
- Support new message entities: CASHTAG and PHONE_NUMBER. (#1179)
    - Cashtag seems to be things like $USD and $GBP, but it seems telegram doesn't currently send them to bots.
    - Phone number also seems to have limited support for now
- Add Bot.send_animation, add width, height, and duration to Animation, and add Filters.animation. (#1172)


Co-authored-by: Jasmin Bom <jsmnbom@gmail.com>
Co-authored-by: code1mountain <32801117+code1mountain@users.noreply.github.com>
Co-authored-by: Eldinnie <pieter.schutz+github@gmail.com>
Co-authored-by: mathefreak1 <mathefreak@hi2.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment