Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VIIRS HNCC composite passing xarray objects to dask #633

Merged
merged 2 commits into from Feb 28, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 27, 2019

See dask/dask#4532 for details. This fixes the poor usage of dask by passing xarray objects to it.

I'm also using this PR to remove the bdist_wheel creation in travis CI given the recent issues discovered with versioneer and wheel creation (see python-versioneer/python-versioneer#170).

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #633 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   78.29%   78.28%   -0.01%     
==========================================
  Files         136      136              
  Lines       19725    19723       -2     
==========================================
- Hits        15443    15441       -2     
  Misses       4282     4282
Impacted Files Coverage Δ
satpy/tests/compositor_tests/test_viirs.py 99.28% <ø> (-0.01%) ⬇️
satpy/composites/viirs.py 83.71% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5dc2c...df5c786. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 28, 2019

Coverage Status

Coverage decreased (-0.002%) to 78.289% when pulling df5c786 on djhoese:bugfix-hncc-dnb into ef5dc2c on pytroll:master.

@djhoese djhoese merged commit ab4956a into pytroll:master Feb 28, 2019
@djhoese djhoese deleted the bugfix-hncc-dnb branch February 28, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants